craue / CraueConfigBundle

Database-stored settings made available via a service for your Symfony project.
MIT License
173 stars 35 forks source link

Update Github Actions #63

Closed franmomu closed 1 year ago

franmomu commented 1 year ago

This is what I would do, but that's based on other setups and personal preference, so feel free to pick up whatever you want or nothing 😄

The changes:

I would also add a job and use a tool for coding standard issues like https://github.com/PHP-CS-Fixer/PHP-CS-Fixer or https://github.com/squizlabs/PHP_CodeSniffer

craue commented 1 year ago

Oh no, my good old install_dependencies.sh script is gone. 😂 I further simplified things and did some changes due to my personal preference (as you already named it). 😉

What do you think?

Well, a CS fixer could be added in a next step, but first things first.

coveralls commented 1 year ago

Coverage Status

coverage: 100.0%. remained the same when pulling 9e02184cd5aa33e9ffd6d2f359f6c68bd0d13ef8 on franmomu:simplify_ga into 2bb8a02b6214346db3c90f1db660db03ae3aee54 on craue:2.7.x.

craue commented 1 year ago

It looks perfect now and will be the blueprint for my other repositories. Thank you, @franmomu.

franmomu commented 1 year ago

Perfect 👌