search

craue / CraueFormFlowBundle

Multi-step forms for your Symfony project.
MIT License
735 stars 118 forks source link

Percentage of completion #261

Closed kklecho closed 7 years ago

kklecho commented 8 years ago

Shell this be something desired in the bundle, please let me know.

I've extended the bundle to retrieve percentage of completion. By default it weights all steps equally, but you can configure by custom step parameter (see #260).

Forgotten settings are auto-filled in proportionally & the numbers scaled in case "furious development" lead someone to configure for percentages that don't sum up to 100.

craue commented 8 years ago

Could you elaborate on this? I'm afraid I don't understand what it's about.

kklecho commented 8 years ago

I'm not sure on this, as you don't want the FormFlow to bloat & what I have in mind may be too large. To put things simple:

//FormFlowInterface.php
public function getPercentageCompleted();

The actual implementation may be very simplistic like 100*stepsCompletedCount/stepsCount. I tried that & for me it turned out insufficient. I wanted to say that e.g. Step1 accounts for 10%, Step2 60% & Step3 30%. That's where #263 came in handy to me.

What are your thoughts?

craue commented 8 years ago

Right now, I'd say this is indeed a rather custom feature that should go into your FormFlow-extending class.