craue / CraueFormFlowBundle

Multi-step forms for your Symfony project.
MIT License
736 stars 118 forks source link

Add an option for removing the reset button #280

Closed Florian-B closed 7 years ago

Florian-B commented 7 years ago

This feature adds an option to remove the reset button because this one is not always necessary.

To remove it, we need to pass an option named craue_formflow_render_reset_button when include CraueFormFlowBundle:FormFlow:buttons.html.twig.

Exemple:

{% include 'CraueFormFlowBundle:FormFlow:buttons.html.twig' with {
        craue_formflow_button_class_last: 'btn btn-primary',
        craue_formflow_button_class_back: 'btn btn-default',
        craue_formflow_button_class_reset: 'btn btn-warning',
        craue_formflow_render_reset_button: false
} %}
coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 99.751% when pulling 84beada5b2c9f7ddc8da1a1df934936b0670d6a7 on Florian-B:remove_reset_btn_option into aaca0758a4abec1144d7b466375e5569226f61bc on craue:master.

craue commented 7 years ago

This should be covered by tests.

Florian-B commented 7 years ago

Done ! I added several tests:

On step one:

On step two:

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 99.751% when pulling a58c8f2e35cb00281b44f0e316e2f0a99efb3e99 on Florian-B:remove_reset_btn_option into aaca0758a4abec1144d7b466375e5569226f61bc on craue:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.0003%) to 99.751% when pulling 57a8c7b7f6e515f189ed3ed8b0f38cf4c8c75a62 on Florian-B:remove_reset_btn_option into aaca0758a4abec1144d7b466375e5569226f61bc on craue:master.

craue commented 7 years ago

Great, could you finally squash all commits into one?

Florian-B commented 7 years ago

Done 😄

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 10ae4ceb4ac90baa54dc6f2317f91d84ab197565 on Florian-B:remove_reset_btn_option into on craue:master.

craue commented 7 years ago

Thank you, @Florian-B.