search

craue / CraueFormFlowBundle

Multi-step forms for your Symfony project.
MIT License
736 stars 118 forks source link

Replace setParent() that does not exist on Definition instances #337

Closed gnutix closed 5 years ago

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.001%) to 99.688% when pulling a2d591db6adca3a18d0900f67fedc41e4a3eae7d on gnutix:autoconfiguration into d3ab5362d421a48c829914bf5af7a7756b1e99c0 on craue:autoconfiguration.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.2%) to 99.53% when pulling ce6291a70ffa48d0fb4cb1be939ea1cdb383af6c on gnutix:autoconfiguration into d3ab5362d421a48c829914bf5af7a7756b1e99c0 on craue:autoconfiguration.

gnutix commented 5 years ago

Tests fail on Symfony 3.4 but pass on 4.3 because I'm relying on code from https://github.com/symfony/dependency-injection/commit/e546fec37cb2692565df5f1da8ff3e865b6babd5#diff-4388d835b7c438233f9e1fa1ca067473 which was released with 4.1... Not sure yet how to write this code for SF 3.4. :/

gnutix commented 5 years ago

Still not working for 3.4, but I need to stop for today, spent too much time on this already. I'll see if I can get a look again later on.

gnutix commented 5 years ago

Fixed by https://github.com/craue/CraueFormFlowBundle/pull/333/commits/d6e0c638036a91e258052b62a43bd769a4bc1f0a