search

craue / CraueFormFlowBundle

Multi-step forms for your Symfony project.
MIT License
736 stars 118 forks source link

Use DataManager to check if current flow exists #359

Closed Warxcell closed 4 years ago

Warxcell commented 4 years ago

Instead of flagging with newInstance = true.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.0009%) to 99.692% when pulling 856a41257dc38bad132246f178d0b4c2a2cf38f1 on Warxcell:use_data_manager_instead_new_instance into 3892860bc6f287f6677edd4ec19d19c47c25841f on craue:master.

craue commented 4 years ago

Good idea! :+1:

Can you rebase to current master? This should make tests pass.

Warxcell commented 4 years ago

Sure, will do later.

I'm also thinking of restructuring in some way - the problem I have is that I have to make multi step form - without persisting actual data temporary somewhere - data will be immediately persisted into it's final location at each step.

The other problem is that user should continue from same step where he left at. For this problem I switched to Doctrine Storage (that's ok) and I was trying to override instanceId (to be same instanceId for same user) - but without luck so far.

craue commented 4 years ago

Thank you, @Warxcell.

I'm also thinking of restructuring in some way - the problem I have is that I have to make multi step form - without persisting actual data temporary somewhere - data will be immediately persisted into it's final location at each step.

Are you sure this is a good idea?

The other problem is that user should continue from same step where he left at. For this problem I switched to Doctrine Storage (that's ok) and I was trying to override instanceId (to be same instanceId for same user) - but without luck so far.

This is already in a separate issue, right?

Warxcell commented 4 years ago

Yeah, it's in separate PR - you can review the way I think about the things: https://github.com/craue/CraueFormFlowBundle/pull/360

if you think it's ok - i will continue in that direction.