search

craue / CraueFormFlowBundle

Multi-step forms for your Symfony project.
MIT License
734 stars 118 forks source link

Use GithubActions and add return types #414

Closed franmomu closed 1 year ago

franmomu commented 1 year ago

The result of the Github Actions can be seen in https://github.com/franmomu/CraueFormFlowBundle/pull/1

This also fixes some deprecations shown using Symfony 6.3 (adding return types)

franmomu commented 1 year ago

friendly ping @craue if you can review this

craue commented 1 year ago

First of all, thanks for all your work. I really appreciate it, @franmomu.

I don't have much experience with GitHub Actions yet, only started playing around for CraueConfigBundle a few months ago. And of course I'd prefer a similar setup in all my repos in order to simplify maintainability. So if you're interested in helping me to achieve this by

Furthermore, I guess it would be better to put everything related to return types (and further changes) into a separate PR to focus on the GHA migration in this one.

Let me know what you think.

craue commented 1 year ago

I finally made some progress and used most of your commits in #417. I'd appreciate your feedback.

It became pretty clear that, while reworking CI, trying to get rid of deprecations also means using your commit about adding return types so that #416 is no longer needed. Sorry for the back & forth.

franmomu commented 1 year ago

closed in favor of https://github.com/craue/CraueFormFlowBundle/pull/417