Remove dbal deprecations

craue / CraueFormFlowBundle

Multi-step forms for your Symfony project.

MIT License

735 stars 118 forks source link

Remove dbal deprecations #419

Closed franmomu closed 6 months ago

franmomu commented 10 months ago

So the first commit uses MySQL for tests, then the second one requires explicitly doctrine/dbal (in dev and requires a minimum version for the users) as it is used in DoctrineStorage (I would also remove support for doctrine/dbal 2 since it's not maintained) and the third one changes array for json type dealing with the conversions.

coveralls commented 10 months ago

coverage: 99.482% (-0.001%) from 99.483% when pulling 70b3a3ff65b574e8e5efd5858d1e0358980fca10 on franmomu:dbal into 0e34cf978441e0a77882c2273ec38efc35cf0927 on craue:master.

craue commented 10 months ago

What do you think about #420? It's meant as an alternative approach to your first commit (Test using MySQL). I'd like to merge that one first (despite CI failing currently) in order to rebase. This way, this PR can really focus on getting rid of the deprecations.

craue commented 10 months ago

JSON type doesn't seem to play well with serialized files. How about using TEXT instead? Tests would be fine.

franmomu commented 10 months ago

JSON type doesn't seem to play well with serialized files. How about using TEXT instead? Tests would be fine.

yep 😞

craue commented 9 months ago

/ping @franmomu

franmomu commented 9 months ago

hey! sorry for late response, what was missing here?

craue commented 6 months ago

Thank you, @franmomu.