search

craue / CraueFormFlowBundle

Multi-step forms for your Symfony project.
MIT License
736 stars 118 forks source link

run tests for DoctrineStorage with MySQL, PostgreSQL, SQLite #420

Closed craue closed 1 year ago

coveralls commented 1 year ago

Coverage Status

coverage: 99.472%. remained the same when pulling 36be0fab6e398b99e82ada2a4c8f2d94d30581f6 on test-doctrine-storage-with-databases into 515871d3de56a80b0cb471e057a9edb5113c1250 on master.

franmomu commented 1 year ago

If we are testing different databases, I think I would add different jobs depending on the database as doctrine/orm does instead of adding new classes, at the end it's about the connection url/dsn.

They pass all tests using sqlite: https://github.com/doctrine/orm/blob/17500f56eaa930f5cd14d765bc2cd851c7d37cc0/.github/workflows/continuous-integration.yml#L29

and then for example using PostgreSQL: https://github.com/doctrine/orm/blob/17500f56eaa930f5cd14d765bc2cd851c7d37cc0/.github/workflows/continuous-integration.yml#L105-L130 they test with different versions of PostgreSQL.

Maybe a phpunit group could be created as well, in this case we only want to pass DoctrineStorage related tests. Anyway, it's up to you 😬

craue commented 1 year ago

I like the idea. Take a look at #421.