search

craue / CraueFormFlowBundle

Multi-step forms for your Symfony project.
MIT License
734 stars 118 forks source link

run tests with MySQL, PostgreSQL, SQLite #421

Closed craue closed 1 year ago

craue commented 1 year ago

Different approach compared to #420. This makes it possible to run specific tests (only those which actually use a database) against several database platforms. I definitely like that the mechanism is easier to understand and tests themselves are kept clean.

What I don't like is that a failed step causes following steps to be skipped so if tests fail with MySQL they won't be run with PostgreSQL and SQLite. Also the SYMFONY_DEPRECATIONS_HELPER will be harder to use with 4 PHPUnit steps.

I wonder why PhotoUploadFlowTest fails with PostgreSQL. 🤔 This at least proves that testing against several database platforms is a good idea. 😂

craue commented 1 year ago

PostgreSQL is fine now, at least with PHP > 7.3. I'm gonna remove support for PHP 7.3 but not within this PR.

Awaiting feedback from @franmomu. 😊

coveralls commented 1 year ago

Coverage Status

coverage: 99.483% (+0.01%) from 99.472% when pulling 1fae5f64096776c20ddbbb3180b67bad96da8f35 on tests-with-databases into 515871d3de56a80b0cb471e057a9edb5113c1250 on master.

craue commented 1 year ago

Alright, now I also got all PHPUnit steps running even in case of failures. 🥳