search

craue / CraueGeoBundle

Doctrine functions for calculating geographical distances in your Symfony project.
MIT License
125 stars 16 forks source link

symfony 4 upgrade #16

Closed tibineogen closed 6 years ago

tibineogen commented 6 years ago

SymfonyConHackday2017

craue commented 6 years ago

I prefer to wait for the release of Symfony 4.0. Would you update the PR once that happened?

craue commented 6 years ago

/ping @tibineogen

craue commented 6 years ago

And would you squash all commits into one when done?

Tilotiti commented 6 years ago

I would be so greatfull if this pull could be out today. I've a big delivery tomorow and this is the last thing I need to finish.

You are the best <3

Tilotiti commented 6 years ago

You are definitively the best ❤️

tibineogen commented 6 years ago

Thanks, I hope I did not hold up your project for too much :)

craue commented 6 years ago

It's fine, @tibineogen. Thank you for contributing.

...and wish fulfilled, @Tilotiti. :angel: 1.5.0 is out. :sparkles:

Tilotiti commented 6 years ago

Just for information, the fixture method doesn't work anymore with SF4 and doctrine/doctrine-fixtures-bundle v3.0.2.

The Option --fixtures disappeared so we are not able to load it anymore.

craue commented 6 years ago

True. Any idea on how to load individual fixtures now?

Tilotiti commented 6 years ago

I didn't used the fixture method (wich is supposed to be only on development environment). I used a command to integrate the zipcode file.

We maybe could adapt this command, implement it in the bundle, and just add an input option to locate the desired file.

https://gist.github.com/Tilotiti/5b69e938475abc896f902d5ea7d3ff93

craue commented 6 years ago

I also thought about adding a command instead, but a fixture is convenient and flexible. So I prefer waiting for a solution within DoctrineFixturesBundle itself, probably by https://github.com/doctrine/DoctrineFixturesBundle/issues/219#issuecomment-352337579 becoming implemented.