search

craustin / triply

Trip Planning Toolkit
http://desolate-thicket-4407.herokuapp.com/#/
3 stars 0 forks source link

Cannot delete people or costs #3

Open craustin opened 10 years ago

craustin commented 10 years ago

This might require changing the way we store items in the Firebase. People and costs are currently sequentially indexed (since in the JS, they're lists). This gets weird if we remove entries.

ESRogs commented 10 years ago

Yeah, I think we should maybe just make guids for everything.

On Sat, Nov 23, 2013 at 2:13 PM, Craig Austin notifications@github.comwrote:

This might require changing the way we store items in the Firebase. People and costs are currently sequentially indexed (since in the JS, they're lists). This gets weird if we remove entries.

— Reply to this email directly or view it on GitHubhttps://github.com/craustin/triply/issues/3#issuecomment-29143044 .

ESRogs commented 10 years ago

Oh, you're already creating random trip ids. We should do that for people and costs too and index by the id.

On Sat, Nov 23, 2013 at 2:54 PM, Eric Rogstad esrogs@gmail.com wrote:

Yeah, I think we should maybe just make guids for everything.

On Sat, Nov 23, 2013 at 2:13 PM, Craig Austin notifications@github.comwrote:

This might require changing the way we store items in the Firebase. People and costs are currently sequentially indexed (since in the JS, they're lists). This gets weird if we remove entries.

— Reply to this email directly or view it on GitHubhttps://github.com/craustin/triply/issues/3#issuecomment-29143044 .

craustin commented 10 years ago

I did it myself for the trip ids so i could make them short and standardized. Think there's a way to get Firebase to do this for us with it's own random ids. The Firebase samples do it.

On Sat, Nov 23, 2013 at 6:15 PM, ESRogs notifications@github.com wrote:

Oh, you're already creating random trip ids. We should do that for people and costs too and index by the id.

On Sat, Nov 23, 2013 at 2:54 PM, Eric Rogstad esrogs@gmail.com wrote:

Yeah, I think we should maybe just make guids for everything.

On Sat, Nov 23, 2013 at 2:13 PM, Craig Austin notifications@github.comwrote:

This might require changing the way we store items in the Firebase. People and costs are currently sequentially indexed (since in the JS, they're lists). This gets weird if we remove entries.

— Reply to this email directly or view it on GitHub< https://github.com/craustin/triply/issues/3#issuecomment-29143044> .

— Reply to this email directly or view it on GitHubhttps://github.com/craustin/triply/issues/3#issuecomment-29144231 .

ESRogs commented 10 years ago

Ah, sounds good.

On Sat, Nov 23, 2013 at 3:17 PM, Craig Austin notifications@github.comwrote:

I did it myself for the trip ids so i could make them short and standardized. Think there's a way to get Firebase to do this for us with it's own random ids. The Firebase samples do it.

On Sat, Nov 23, 2013 at 6:15 PM, ESRogs notifications@github.com wrote:

Oh, you're already creating random trip ids. We should do that for people and costs too and index by the id.

On Sat, Nov 23, 2013 at 2:54 PM, Eric Rogstad esrogs@gmail.com wrote:

Yeah, I think we should maybe just make guids for everything.

On Sat, Nov 23, 2013 at 2:13 PM, Craig Austin < notifications@github.com>wrote:

This might require changing the way we store items in the Firebase. People and costs are currently sequentially indexed (since in the JS, they're lists). This gets weird if we remove entries.

— Reply to this email directly or view it on GitHub< https://github.com/craustin/triply/issues/3#issuecomment-29143044> .

— Reply to this email directly or view it on GitHub< https://github.com/craustin/triply/issues/3#issuecomment-29144231> .

— Reply to this email directly or view it on GitHubhttps://github.com/craustin/triply/issues/3#issuecomment-29144259 .

ESRogs commented 10 years ago

It looks like you can:

http://stackoverflow.com/questions/14963776/how-to-access-specific-data-with-firebase

Though to deal with the keys issue, we might end up needing to create our own.

On Sat, Nov 23, 2013 at 3:17 PM, Craig Austin notifications@github.comwrote:

I did it myself for the trip ids so i could make them short and standardized. Think there's a way to get Firebase to do this for us with it's own random ids. The Firebase samples do it.

On Sat, Nov 23, 2013 at 6:15 PM, ESRogs notifications@github.com wrote:

Oh, you're already creating random trip ids. We should do that for people and costs too and index by the id.

On Sat, Nov 23, 2013 at 2:54 PM, Eric Rogstad esrogs@gmail.com wrote:

Yeah, I think we should maybe just make guids for everything.

On Sat, Nov 23, 2013 at 2:13 PM, Craig Austin < notifications@github.com>wrote:

This might require changing the way we store items in the Firebase. People and costs are currently sequentially indexed (since in the JS, they're lists). This gets weird if we remove entries.

— Reply to this email directly or view it on GitHub< https://github.com/craustin/triply/issues/3#issuecomment-29143044> .

— Reply to this email directly or view it on GitHub< https://github.com/craustin/triply/issues/3#issuecomment-29144231> .

— Reply to this email directly or view it on GitHubhttps://github.com/craustin/triply/issues/3#issuecomment-29144259 .

ESRogs commented 10 years ago

FYI, I'm planning to spend some time thinking about / working on this issue next.