search

crawford / tailor

GitHub bot that validates patches before they can be merged
Apache License 2.0
18 stars 10 forks source link

Add support for querying files in a commit #12

Open crawford opened 7 years ago

crawford commented 7 years ago

Things to consider:

arithx commented 7 years ago

Should we also expose helper attributes like Net Additions & Removals?

crawford commented 7 years ago

If diffs are represented as a list of additions and a list of removals, the length operator will make that simple. I'm not sure the best way to represent a diff though.

arithx commented 7 years ago

In support of checks like "vendor operations must be done in seperate commits" it'd be nice to expose even just the filename in an initial implementation while we wait to figure out how to expose things like diffs, etc.

sdemos commented 7 years ago

What kinds of behaviors would a diff be useful for? I can't really think of any that seem to fall in the scope of this project. Seems like that is taken care of by the code review part, or any number of other ci/linting tools.

I think it does make sense for lists of added/removed/changed files to be included though, for automated review of vendoring operations. Seems simple enough to just include that in the provided context as lists of each respective operation.

crawford commented 7 years ago

The idea was to help detect simple changes, for example, if you wanted to make sure that a version string is updated in every location.