search

crawler-commons / url-frontier

API definition, resources and reference implementation of URL Frontiers
Apache License 2.0
45 stars 12 forks source link

NGI0 - Updating licensing aspects according REUSE #20

Closed lnceballosz closed 3 years ago

lnceballosz commented 3 years ago

Hello,

We have been working within the NGI0 framework, helping projects with their licensing and copyright management. After a quick check on your repository,I would like to propose some updates regarding copyright and licensing information. REUSE specifications intend to make licensing easier by setting one way to display all this legal information through comment headers on source files that can be human - and machine – readable.

The REUSE tool makes the process of applying licenses to files and compliance checking much easier. Check this screencast:

https://download.fsfe.org/videos/reuse/screencasts/reuse-tool.gif

Feel completely free to adopt these specifications by merging this pull request.

REUSE Features:

Files missing copyright and licensing information:

I added the SPDX headers with copyright and license information to all the copyrightable files.

Please also double check if the personal information in the headers is correct and consistent.

I provided license information to README file as well.

I have created two license files for the two images (logo) in your repository (I licensed them under the main license of the project Apache-2.0. In case you want to license them under a different one, please modify the files and add the license text to the LICENSES directory)

No contribution policy:

We have noticed that your project does not have a contribution policy. Therefore, we strongly recommend you to implement one. To get further information about this please check our documentation: https://download.fsfe.org/NGI0/V2/FSFE%20-%204%20-%20Free%20Software%20Contribution%20Policy.pdf

Further REUSE compliance

In case you find REUSE useful, we offer a wide range of tools to help you to continuously check and display compliance with the REUSE guidelines.

Hope that helps and thank you very much for the amazing job!

jnioche commented 3 years ago

thanks @lnceballosz The code in the API module is automatically generated, managing these additions manually would not be practical. Adding licenses to the images feels a bit of an overkill. The images are part of the whole project, the licensing of it applied to them as well. I'll have a look at the contributions policy

lnceballosz commented 3 years ago

Hi, thank you for your response and for the attention to my PR. Please keep in mind that if you need any support in implementing REUSE or other legal features, we can be of help. Best, Lina

jnioche commented 3 years ago

Implemented changes in #5068ea5 Will open a new issue for the contributions policy Thanks @lnceballosz