Preventing IgniteHeartbeat race condition on the start of IgniteService (Issue #72)

[michaeldinzinger]

Signed-off-by: Michael Dinzinger michael.dinzinger@uni-passau.de

Thanks for contributing to URL Frontier, your efforts are appreciated!

Developer Certificate of Origin

By contributing to URL Frontier, you accept and agree to the following terms and conditions (the Developer Certificate of Origin) for your present and future contributions submitted to URL Frontier. Please refer to the Developer Certificate of Origin section in CONTRIBUTING.md for details.

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Before opening a PR, please check that:

• You've squashed your commits into a single one
• You've described what the PR does or at least point to a related issue
• You've signed-ff your commits with 'git commit -s'

Thanks!

[jnioche]

A simpler approach would be to force FrontierServices to have a constructor containing (String host, String port) so that these values would be set before the Hearbeat thread starts working. Alternatively, we could introduce a new method start() for FrontierServices and call that after service.setHostAndPort(host, port); in the server class. We'd separate the instantiation from the actual starting of the various subthreads. What do you think @michaeldinzinger?

[michaeldinzinger]

I like the first idea to add host and port to the constructor. It should fix the problem and is easy to implement and understand (Don't be irritated that I uploaded two commits. First, I looked at the idea to add the start() method, but reverted the changes and implemented the idea to modify the constructor; it seems to be better coding style) However, it has to be considered that the constructor has to be changed in all implementations, also in the opensearch implementation as soon as it would use this newer version of the urlfrontier code, in the future

[jnioche]

Perfect, thanks @michaeldinzinger