crawler-commons / url-frontier

API definition, resources and reference implementation of URL Frontiers
Apache License 2.0
47 stars 12 forks source link

Modifying the delete functionality for ignite.purge (Issue #74) #81

Closed michaeldinzinger closed 1 year ago

michaeldinzinger commented 1 year ago

Signed-off-by: Michael Dinzinger michael.dinzinger@uni-passau.de

Thanks for contributing to URL Frontier, your efforts are appreciated!

Developer Certificate of Origin

By contributing to URL Frontier, you accept and agree to the following terms and conditions (the Developer Certificate of Origin) for your present and future contributions submitted to URL Frontier. Please refer to the Developer Certificate of Origin section in CONTRIBUTING.md for details.

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Before opening a PR, please check that:

Thanks!

michaeldinzinger commented 1 year ago

Within this implementation, in case the ignite.purge flag is set and the directory cannot be create or cleaned, a RuntimeException is thrown. Before it was only a Error log. However, it appears to me when you set the ignite.purge flag, you expect the corresponding directories to be clean. If they are not clean, you will just run in some unexpected, incomprehensible behavior afterwards. So I put the RuntimeException to be sure, but it can also be substituted by the previous Error message again

jnioche commented 1 year ago

Perfect, thanks @michaeldinzinger