crawler-commons / url-frontier

API definition, resources and reference implementation of URL Frontiers
Apache License 2.0
44 stars 11 forks source link

Making the metrics variables for GetURLs protected #84

Closed michaeldinzinger closed 1 year ago

michaeldinzinger commented 1 year ago

Hello,

in an service implementation, which inherits from the abstract implementation of the FrontierService in this repository, we want to override the GetURLs method. Besides that, we want to use furtheron use the Prometheus metrics, which help to monitor the Frontier service and, among others, the number and latency of GetURLs calls. Therefore, it is necessary to make the three corresponding variables in AbstractFrontierService.java protected instead of private. Thank you!

jnioche commented 1 year ago

Good idea, thanks @michaeldinzinger