Closed MattiSG closed 1 year ago
hi @MattiSG
Thanks for the PR. The keys are definitely not based on the top level domain (e.g. .com) but on the paid one (e.g. digitalpebble.com). Your other suggestions are good. If you commit a change, can you please sign it so that it passes the DCO? Thanks
Hi @jnioche and thanks for your quick reply :)
To be honest, the time and energy it will take me to clone the repo locally, set up a signing key, push, update my PR, is just not worth it for me for a handful of typos in a README that I fixed as a courtesy when reading through the text. Feel free to just copy-paste what is relevant to you, update the doc and close this PR —or credit me with Co-Authored-By: Matti Schneider <gh@mattischneider.fr>
in the commit body. Thank you for your understanding!
the paid one
I was quite confused by that name. I would then suggest using simply “domain name” 🙂
To be honest, the time and energy it will take me to clone the repo locally, set up a signing key, push, update my PR, is just not worth it for me for a handful of typos in a README that I fixed as a courtesy when reading through the text. Feel free to just copy-paste what is relevant to you, update the doc and close this PR —or credit me with
Co-Authored-By: Matti Schneider <gh@mattischneider.fr>
in the commit body. Thank you for your understanding!
sure. BTW you shouldn't need to set up a signing key for a DCO though, just add '-s' to the commit command , see https://www.secondstate.io/articles/dco/
you shouldn't need to set up a signing key for a DCO though, just add '-s' to the commit command
The main friction point for me was having to switch from GitHub online edition to local clone and commands 🙂
Thanks for the credit!
Thanks for contributing to URL Frontier, your efforts are appreciated!
Developer Certificate of Origin
By contributing to URL Frontier, you accept and agree to the following terms and conditions (the Developer Certificate of Origin) for your present and future contributions submitted to URL Frontier. Please refer to the Developer Certificate of Origin section in
CONTRIBUTING.md
for details.Before opening a PR, please check that:
Thanks!