added pool.Size() and pool.ExecScript()

crawshaw / sqlite

Go SQLite3 driver

ISC License

561 stars 67 forks source link

added pool.Size() and pool.ExecScript() #108

Closed DrGo closed 2 years ago

DrGo commented 3 years ago

Hi @AdamSLevy Would this approach work to address #101? All tests are passing (including a new test for this feature).

Thanks, /salah

AdamSLevy commented 3 years ago

Thanks for the PR. I will be catching up on issues and PRs on this repo this weekend and over the next week since I'll have a break from work.

AdamSLevy commented 2 years ago

@DrGo Can you please isolate your changes for sqlitex.Pool.Size and ExecScript from your changes to sqlitex.File? I would like to consider each independently.

Even though this package does not have a major v1 yet, I would still like to minimize breaking API changes such as the changes you made to sqlitex.File.

I am reviewing what I see here but I'm going to close this PR for you because you will need to isolate your changes into branches and re-submit the PR from each branch.