Compilation warning about memcpy with gcc 11.2.0

MEschenbacher commented 2 years ago

Hey, I'm using version 0.3.2 of this lib with go version 1.17.2 and go build prints a compilation warning but the build of my project succeeds.

I have applied system updates last night and I believe compiler versions have changed: gcc from 10.2.1 to 11.2.0

# crawshaw.io/sqlite
In file included from ../../../go/pkg/mod/crawshaw.io/sqlite@v0.3.2/static.go:19:
../../../go/pkg/mod/crawshaw.io/sqlite@v0.3.2/./c/sqlite3.c: In function ‘sqlite3Fts5IndexQuery’:
../../../go/pkg/mod/crawshaw.io/sqlite@v0.3.2/./c/sqlite3.c:220863:18: warning: ‘memcpy’ specified bound 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=]
220863 |     if( nToken ) memcpy(&buf.p[1], pToken, nToken);
       |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

anacrolix commented 2 years ago

It's quite possible this would get fixed upstream in sqlite.

bobhenkel commented 2 years ago

I'm on go1.16.8 linux/amd64 and seeing the same issue.

AdamSLevy commented 2 years ago

This is mentioned on the forum here. Warnings like this creep in from time to time and generally are nothing to be concerned about. drh knows what he's doing :)

https://sqlite.org/forum/forumpost/f5eed70bd46ede56?t=h