search

craymichael / CNN_LCD

CNNs for Loop-Closure Detection on the Oxford New College and City Centre Datasets
GNU General Public License v3.0
58 stars 14 forks source link

overfeat failed #13

Closed Be997398715 closed 3 years ago

Be997398715 commented 3 years ago

I try to use overfeat model by python2 to reconstruct your paper result, however i can't. many problems to deal. could you give the final overfeat pr curve and map as well as other models? thanks for your help.

craymichael commented 3 years ago

Hi, as the README states, I am not the author of the paper - I merely implemented the methods as I understood them, so I do not have the exact results from the paper (mine don't fare as well). Furthermore, the implementation of OverFeat that I used is now broken, please see https://github.com/sermanet/OverFeat/issues/39 and my response in another issue https://github.com/craymichael/CNN_LCD/issues/10#issuecomment-718340086. Other CNN models are available as detailed in the README.

1274622976 commented 3 years ago

If the overfeat model is no longer available, how should this code be modified? Is there any other closed-loop detection code based on deep learning available?Please provide an open source code，thank you! I'm looking forward to your reply. Thank you for your help!

------------------ 原始邮件 ------------------ 发件人: "craymichael/CNN_LCD" <notifications@github.com>; 发送时间: 2020年12月8日(星期二) 下午3:28 收件人: "craymichael/CNN_LCD"<CNN_LCD@noreply.github.com>; 抄送: "Subscribed"<subscribed@noreply.github.com>; 主题: Re: [craymichael/CNN_LCD] overfeat failed (#13)

Hi, as the README states, I am not the author of the paper - I merely implemented the methods as I understood them, so I do not have the exact results from the paper (mine don't fare as well). Furthermore, OverFeat is broken, please see sermanet/OverFeat#39 and my response in another issue #10 (comment).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

craymichael commented 3 years ago

You'd have to modify cnn_models.py with whatever other implementation that you're able to find. In get_model_features(...) you need to override the overfeat model with something that returns feature descriptors for all images (imgs). In the smaller version of overfeat, they use the 19th layer, and the 20th layer for the larger model.

I've moved away from SLAM several years ago, so I'm not familiar with what the state-of-the-art looks like. In the past I have used full-blown packages but nothing targetting LCD specifically. I would check out the list of LCD algorithms on PapersWithCode (ranked by GitHub stars): https://paperswithcode.com/task/loop-closure-detection/

1274622976 commented 3 years ago

If you use it in Python 2.7, do you need to download the overfeat model? I use tensorflow framework because I just started to learn about closed-loop detection, and I don't know how to change the code. I use Python 3.7, so overfeat display can't be used, but switching to Python 2.7 can't run through the code. In addition, I use GPU, because of the code problem, there is no progress for a long time, hope to get your help, I will be very grateful, looking forward to your reply, thank you!

------------------ 原始邮件 ------------------ 发件人: "craymichael/CNN_LCD" <notifications@github.com>; 发送时间: 2020年12月8日(星期二) 下午4:00 收件人: "craymichael/CNN_LCD"<CNN_LCD@noreply.github.com>; 抄送: "浅笑心柔"<1274622976@qq.com>;"Comment"<comment@noreply.github.com>; 主题: Re: [craymichael/CNN_LCD] overfeat failed (#13)

You'd have to modify cnn_models.py with whatever other implementation that you're able to find. In get_model_features(...) you need to override the overfeat model with something that returns feature descriptors for all images (imgs). In the smaller version of overfeat, they use the 19th layer, and the 20th layer for the larger model.

I've moved away from SLAM several years ago, so I'm not familiar with what the state-of-the-art looks like. In the past I have used full-blown packages but nothing targetting LCD specifically. I would check out the list of LCD algorithms on PapersWithCode (ranked by GitHub stars): https://paperswithcode.com/task/loop-closure-detection/

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

craymichael commented 3 years ago

So, when the implementation did work, it only worked with Python 2.7. Now it doesn't work at all (see the previously linked issues). Unfortunately, unless you are to use the other TF Slim models, overfeat does not work at this time. The TF Slim models should definitely work on GPU

On Dec 8 2020, at 3:20 am, 1274622976 notifications@github.com wrote:

If you use it in Python 2.7, do you need to download the overfeat model? I use tensorflow framework because I just started to learn about closed-loop detection, and I don't know how to change the code. I use Python 3.7, so overfeat display can't be used, but switching to Python 2.7 can't run through the code. In addition, I use GPU, because of the code problem, there is no progress for a long time, hope to get your help, I will be very grateful, looking forward to your reply, thank you!

------------------ 原始邮件 ------------------ 发件人: "craymichael/CNN_LCD" <notifications@github.com>; 发送时间: 2020年12月8日(星期二) 下午4:00 收件人: "craymichael/CNN_LCD"<CNN_LCD@noreply.github.com>; 抄送: "浅笑心柔"<1274622976@qq.com>;"Comment"<comment@noreply.github.com>; 主题: Re: [craymichael/CNN_LCD] overfeat failed (#13)

You'd have to modify cnn_models.py with whatever other implementation that you're able to find. In get_model_features(...) you need to override the overfeat model with something that returns feature descriptors for all images (imgs). In the smaller version of overfeat, they use the 19th layer, and the 20th layer for the larger model. I've moved away from SLAM several years ago, so I'm not familiar with what the state-of-the-art looks like. In the past I have used full-blown packages but nothing targetting LCD specifically. I would check out the list of LCD algorithms on PapersWithCode (ranked by GitHub stars): https://paperswithcode.com/task/loop-closure-detection/ — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub (https://link.getmailspring.com/link/E2B58765-D247-4D69-8439-EF02EBD669B8@getmailspring.com/0?redirect=https%3A%2F%2Fgithub.com%2Fcraymichael%2FCNN_LCD%2Fissues%2F13%23issuecomment-740462326&recipient=cmVwbHkrQUU1TVRDSzRVTUtBS05PN1pNNUFPSzU1M01NRDdFVkJOSEhDMlBLSFRRQHJlcGx5LmdpdGh1Yi5jb20%3D), or unsubscribe (https://link.getmailspring.com/link/E2B58765-D247-4D69-8439-EF02EBD669B8@getmailspring.com/1?redirect=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAE5MTCMN3AZTCD7UCTX5MO3STXOT7ANCNFSM4URJCJ6A&recipient=cmVwbHkrQUU1TVRDSzRVTUtBS05PN1pNNUFPSzU1M01NRDdFVkJOSEhDMlBLSFRRQHJlcGx5LmdpdGh1Yi5jb20%3D).