search

craysiii / binance

API Wrapper for the Binance cryptocurrency exchange written in Ruby.
MIT License
97 stars 79 forks source link

Fix can't modify frozen String error #38

Open andyklimczak opened 4 years ago

andyklimczak commented 4 years ago

Cannot use shovel method with frozen strings in Ruby 2.7

muxahu3bm commented 3 years ago

Hello, what about this PR? There is no works without it on Ruby 2.7.* = (

craysiii commented 3 years ago

Apologies,

I have been very busy with work and have not had time to pay attention to my personal projects in a long time. I will review the PR over the weekend and publish if it looks good.

From: Mikhail Zadera notifications@github.com Sent: Wednesday, September 16, 2020 10:47:11 PM To: craysiii/binance binance@noreply.github.com Cc: Charles Ray Shisler III charles@cray.io; Review requested review_requested@noreply.github.com Subject: Re: [craysiii/binance] Fix can't modify frozen String error (#38)

Hello, what about this PR? There is no works without it on Ruby 2.7.* = (

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHubhttps://github.com/craysiii/binance/pull/38#issuecomment-693917368, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAKSZT5TVYTV32GAATOYORLSGGPF7ANCNFSM4KZ6TVKQ.