search

crayzeewulf / libserial

Serial Port Programming in C++
BSD 3-Clause "New" or "Revised" License
398 stars 141 forks source link

Missing stdexcept? #121

Closed cjvaughter closed 5 years ago

cjvaughter commented 5 years ago

I can't build without adding #include <stdexcept> to SerialPortConstants.h Am I missing something?

crayzeewulf commented 5 years ago

@cjvaughter Could you please post the Linux distribution and compiler version you are using? Also, are you building the master branch or the dev branch?

cjvaughter commented 5 years ago

Distro: pipaOS (Raspbian-based) Compiler: g++ 4.9.2 Branch: master

Everything works fine after adding the header. To be honest, I'm not really sure how it could compile without it.

mcsauder commented 5 years ago

Hi @cjvaughter , the dev branch contains that include, so this issue will be resolved as soon as the next dev->master PR is created/accepted.

Would you be willing to checkout the dev branch and verify that it corrects the issue you have identified?

Thanks!

cjvaughter commented 5 years ago

That does indeed fix the problem, so I'll go ahead and close this. Thanks.