search

crayzeewulf / libserial

Serial Port Programming in C++
BSD 3-Clause "New" or "Revised" License
406 stars 142 forks source link

Add pkg-config install to cmake build. #163

Closed Crystalix007 closed 4 years ago

Crystalix007 commented 4 years ago

Added the required steps in the CMake build to populate the pkg-config template and install it into the pkg-config directory.

mcsauder commented 4 years ago

That's awesome! This works on my Ubuntu 20.04 machine and a fresh clone of the repo. This looks good to me.

@crayzeewulf , you have a better eye for this than I do, but from my side it looks good.

Thanks @Crystalix007 !

crayzeewulf commented 4 years ago

Awesome! I will have the opportunity to test it out tomorrow evening. I will let you know how it goes.

crayzeewulf commented 4 years ago

I completely forgot that I had done this in cmake_pkg_config_integration branch (update: this branch has been deleted now) back in April. See this. I should have merged it.

crayzeewulf commented 4 years ago

I do like @Crystalix007's solution better because it works for both CMake and autotools.

crayzeewulf commented 4 years ago

Thanks, @Crystalix007. I will abandon my branch now that your solution has been merged.

Crystalix007 commented 4 years ago

I completely forgot to check actually. I'll make sure to check that sort of thing before doing my next PR. Thanks.