search

crazoter / panplus

A chrome extension that improves the webcasting experience for panopto.
GNU General Public License v3.0
7 stars 7 forks source link

Silence Trimming no longer works #17

Open crazoter opened 4 years ago

crazoter commented 4 years ago

Describe the bug Silence trimming functionality has stopped working for reasons undetermined. Video plays as per normal without removing silences.

Failed Solution There exists a new Chrome extension that now allows you to skip silences in any web-based video player. https://chrome.google.com/webstore/detail/skip-silence/fhdmkhbefcbhakffdihhceaklaigdllh/related?hl=en

However, The chrome extension raised does not support multiple videos on the same page and thus does not support Panopto's webcasting system (where only 1 video contains the audio, and the two videos are synced).

crazoter commented 4 years ago

Fixed; this was due to HLS.js removing their observer variable. Attaching a listener to the object can now be directly done to the object.

Will push and update once tests are performed.

crazoter commented 3 years ago

Update: not sure if this applies to all Panopto webcasts, but some webcasts no longer use flowplayer() and instead probably use video-js entirely. This prevents silence trimming from working because the HLS engine cannot be reached (at least, I have not researched enough to find a new way to do so)