crazy-max / .github

1 stars 3 forks source link

gotest-annotations: don't only post annotations for _test.go files #9

Closed jedevc closed 1 year ago

jedevc commented 1 year ago

In the context of https://github.com/docker/buildx/pull/1770, I discovered that only files that end in _test.go are detected for annotations. This meant annotations weren't posted because the names of the test files reflected the name of the commands file, e.g. so tests/build.go tested commands/build.go.

Ideally, we should post annotations no matter which file the failure occurs in, which could also occur if a test helper failed which was not in a _test.go file.

jedevc commented 1 year ago

cc @crazy-max