crazy-max / diun

Receive notifications when an image is updated on a Docker registry
https://crazymax.dev/diun/
MIT License
2.96k stars 112 forks source link

Change "Skipping notification" log from DBG to INF #1196

Open fam4r opened 3 months ago

fam4r commented 3 months ago

Support guidelines

I've found a bug and checked that ...

Description

When DIUN skips a notification (e.g. on first check) the related log entry is shown only on a debug log level, which may be confusing. In my case I was trying to debug notifications (specifically Telegram), while they are completely functional. Switching to debug logs made me observe the true reason on why the notification was not sent.

Expected behaviour

Assign the "Skipping notification" log to the info level

Actual behaviour

The "Skipping notification" is only shown at debug level

Steps to reproduce

  1. docker compose up -d && docker compose logs -f

Diun version

4.28.0

Docker info

docker info
Client:
 Version:    26.1.4
 Context:    default
 Debug Mode: false
 Plugins:
  compose: Docker Compose (Docker Inc.)
    Version:  2.27.1
    Path:     /usr/lib/docker/cli-plugins/docker-compose

Server:
 Containers: [REDACTED]
  Running: [REDACTED]
  Paused: 0
  Stopped: [REDACTED]
 Images: [REDACTED]
 Server Version: 26.1.4
 Storage Driver: overlay2
  Backing Filesystem: extfs
  Supports d_type: true
  Using metacopy: true
  Native Overlay Diff: false
  userxattr: false
 Logging Driver: json-file
 Cgroup Driver: systemd
 Cgroup Version: 2
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local splunk syslog
 Swarm: inactive
 Runtimes: io.containerd.runc.v2 runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: ae71819c4f5e67bb4d5ae76a6b735f29cc25774e.m
 runc version:
 init version: de40ad0
 Security Options:
  seccomp
   Profile: builtin
  cgroupns
 Kernel Version: 6.9.4-arch1-1
 Operating System: Arch Linux
 OSType: linux
 Architecture: x86_64
 CPUs: 8
 Total Memory: 31.2GiB
 Name: [REDACTED]
 ID: [REDACTED]
 Docker Root Dir: /var/lib/docker
 Debug Mode: false
 Experimental: false
 Insecure Registries:
  127.0.0.0/8
 Live Restore Enabled: false

Docker Compose config

No response

Logs

diun  | Tue, 18 Jun 2024 18:40:17 CEST INF New image found image=lscr.io/linuxserver/mariadb:latest provider=docker
diun  | Tue, 18 Jun 2024 18:40:17 CEST DBG Manifest saved to database image=lscr.io/linuxserver/mariadb:latest provider=docker
diun  | Tue, 18 Jun 2024 18:40:17 CEST DBG Skipping notification (first check) image=lscr.io/linuxserver/mariadb:latest provider=docker

Additional info

No response