search

crazy-max / docker-flarum

Flarum Docker image
MIT License
197 stars 31 forks source link

Bump to 1.0.4 #43

Closed blackandred closed 3 years ago

blackandred commented 3 years ago

Hi,

Could the version be bumped to 1.0.4? :)

https://discuss.flarum.org/d/27852-flarum-10-release-announcements/6

crazy-max commented 3 years ago

Unfortunately flarum/core (1.0.4) is desync with flarum/flarum (1.0.0) which this Docker image uses. I think they should also create release for the compose project when patch are released for core in their compose: https://github.com/flarum/flarum/blob/bfc0693fc094abd814448ba8bfe006108b7ccb95/composer.json#L24

Is it possible to do that on your side @luceos?

luceos commented 3 years ago

From what I can see you use composer create project. If you drop the minimum stability flag (even without doing that) it will automatically download the latest flarum/core.

I see no reason why we need to tag a new skeleton version as the skeleton does not lock the core version at all..

crazy-max commented 3 years ago

@luceos

I see no reason why we need to tag a new skeleton version as the skeleton does not lock the core version at all..

Yeah it kinda breaks reproducibility because the outcome is different with the same compose project version for Docker images or other integrations. I guess I will need to stick the core version to the latest release myself in the compose file.

luceos commented 3 years ago

What you are asking for is to fix the constraint to flarum/core in flarum/flarum to an exact version. This makes sense from a docker standpoint, but not from any other perspective. No one will be able to update flarum the normal way with composer thereafter.

A solution to your problem would be to fork the skeleton (because that's what it is meant for), set that constraint in your fork, add the Dockerfile to that fork and ship that. Alternatively you can run composer create-project with the --no-install flag, then use composer require flarum/core:1.0.4 thereafter. To force loading the specific version.

Now onto the actual question of this issue, which is about bumping this docker image to 1.0.4. I just tested the image and the installation procedure contained within, and as expected it installs 1.0.4 by default. As such there's no need to take any action.

crazy-max commented 3 years ago

A solution to your problem would be to fork the skeleton (because that's what it is meant for), set that constraint in your fork, add the Dockerfile to that fork and ship that. Alternatively you can run composer create-project with the --no-install flag, then use composer require flarum/core:1.0.4 thereafter. To force loading the specific version.

Seems like a good way to do it thanks!

Now onto the actual question of this issue, which is about bumping this docker image to 1.0.4. I just tested the image and the installation procedure contained within, and as expected it installs 1.0.4 by default. As such there's no need to take any action.

Yes also tested myself and indeed 1.0.4 is installed.