search

crazy-max / docker-rtorrent-rutorrent

rTorrent and ruTorrent Docker image
MIT License
457 stars 103 forks source link

rtorrent.rc: fix delete data when removing torrent issue #225

Closed V33m closed 1 year ago

V33m commented 1 year ago

Minor PR which comments out a line in .rtorrent.rc defining that when a torrent is removed, the data is always deleted. This is quite controversal as you have the erasedata plugin for that scenario. So, for those who actually wants to always delete data when removing a torrent, they can simply uncomment the line and skip using the erasedata plugin.

Tested and it works as intended, similar to the findings in https://github.com/crazy-max/docker-rtorrent-rutorrent/issues/199

Related issue which will be fixed: https://github.com/crazy-max/docker-rtorrent-rutorrent/issues/199 PR which can be closed after merging: https://github.com/crazy-max/docker-rtorrent-rutorrent/pull/203

stickz commented 1 year ago

@crazy-max We fixed a race condition with the erasedata plugin on ruTorrent version 4 in https://github.com/Novik/ruTorrent/commit/2f59732ead6b086d849b2addb972f43c48b30d71 . It will properly delete torrent data now. This workaround to always delete data is no longer desirable. It should be removed entirely.

The erasedata plugin allows the user to choose when removing a torrent:

  1. Delete just the torrent and preserve the torrent data.
  2. Delete both the torrent and the torrent data.

It's a default plugin that should always be enabled. There's no reason to ever disable it anymore. It's modular and just enables torrent deletion options on the Graphical User Interface. It's compatible with any other type of script and works as intended.