crazy-max / docker-rtorrent-rutorrent

rTorrent and ruTorrent Docker image
MIT License
457 stars 103 forks source link

Remove erase data workaround #229

Closed stickz closed 1 year ago

stickz commented 1 year ago

This workaround is no longer desirable, as discussed here: https://github.com/crazy-max/docker-rtorrent-rutorrent/pull/225#issuecomment-1500285041

closes #199 closes #203 closes #225

stickz commented 1 year ago

I tested the erasedata plugin by building locally and running the docker image. It worked as intended.

crazy-max commented 1 year ago

@stickz I introduced this change in this Docker image so users won't be able to delete a torrent without deleting data. This is to avoid orphan data on disk. This is useful when you have a shared seedbox for example so you don't need to find out which data is orphan or not when you want to freeup disk space. Would it be possible to make some changes to the erasedata plugin so it would be able to enforce deleting torrent AND data (as a setting option)?

stickz commented 1 year ago

@stickz I introduced this change in this Docker image so users won't be able to delete a torrent without deleting data. This is to avoid orphan data on disk. This is useful when you have a shared seedbox for example so you don't need to find out which data is orphan or not when you want to freeup disk space. Would it be possible to make some changes to the erasedata plugin so it would be able to enforce deleting torrent AND data (as a setting option)?

@crazy-max ruTorrent version 4.0.4 has been released. https://github.com/Novik/ruTorrent/releases/tag/v4.0.4

I have created the feature requested on the ruTorrent web interface. It's required to edit the value of $replaceRemoveTorrent to true in plugins/erasedata/conf.php to enable the one button torrent remove feature. It's recommend to add an environment variable. The user will NOT be required to use the feature when running the docker image or edit a configuration file to enable it.

XxAcielxX commented 1 year ago

Glad to know after 4 months, the fix has been merged finally.

notDavid commented 1 year ago

Hi there, just a note that existing users who upgrade/run 'docker compose pull' probably won't notice this change and stay with RU_REMOVE_CORE_PLUGINS=erasedata,httprpc in rtorrent-rutorrent.env...