rTorrent: Add stability patches

crazy-max / docker-rtorrent-rutorrent

rTorrent and ruTorrent Docker image

MIT License

503 stars 112 forks source link

rTorrent: Add stability patches #286

Closed stickz closed 11 months ago

stickz commented 11 months ago

This commit adds multiple stability patches to rtorrent. I have tested these for multiple months. The reason for modifying the software is to resolve stability issues. The software owner is no longer releasing new versions.

libtorrent

Fixes an issue where the throttle plugin on ruTorrent is required to limit upload/download speed to 1gbps.

rTorrent

Fixes a crash caused by some hardening flags during the build process.
Fixes a crash caused by ruTorrent sending invalid xmlrpc data to rTorrent.
Fixes a crash caused by external configurations sending invalid xmlrpc data to rTorrent.
Fixes an issue where torrent information will not update if too many torrents are running.
Fixes an issue where a power loss during torrent session saving will corrupt torrents.

stickz commented 11 months ago

@crazy-max I can see from the build log these patches installed successfully and the build passed. I do not have a configuration to build this docker image. The only step required to build the docker image and ensure rTorrent runs properly before pushing changes. I have tested these changes for months. There should be zero issues and significantly improved rTorrent stability.

stickz commented 11 months ago

Overall LGTM thanks

All fixed up. Suggestions implemented.

crazy-max commented 11 months ago

Small nit as follow-up would be to update this section in the README: https://github.com/crazy-max/docker-rtorrent-rutorrent#features about Latest rTorrent / libTorrent release compiled from source to say some patches are also applied to enhance rTorrent stability or smth like that.

stickz commented 11 months ago

Small nit as follow-up would be to update this section in the README: https://github.com/crazy-max/docker-rtorrent-rutorrent#features about Latest rTorrent / libTorrent release compiled from source to say some patches are also applied to enhance rTorrent stability or smth like that.

I will update that next pull request when 10gbps throttle support is added. This container will be the first to support 10gbps by default on ruTorrent with throttling capabilities. This will bring the configuration into the next decade!