search

crazy-max / docker-rtorrent-rutorrent

rTorrent and ruTorrent Docker image
MIT License
457 stars 103 forks source link

Docker image building improvements #292

Closed stickz closed 6 months ago

stickz commented 6 months ago
  1. Instead of building all the platforms at once, build them as a separate jobs.
  2. Build c-ares and curl with cmake to significantly speed along the build process.
  3. Disable build warnings for xmlrpc, libtorrent and rtorrent to speed along the build process.
  4. Fixed a critical issue where xmlrpc and libtorrent was not being built with the intended flags.

This should resolve timeout problems for PRs.

stickz commented 6 months ago

@crazy-max I was unable to test my changes in #291 due to GitHub Actions time-outs. So I made you a brand new workflow for GitHub pull requests, built c-ares and curl with cmake and disabled gcc warnings during build for some software.

stickz commented 6 months ago

Sorry about all that building. When I separated the tasks and silenced warnings, I saw the rTorrent software stack was not building with the intended flags. Everything is fixed now. We have 5m feedback for x86 and 40m feedback for ARM.

The build process for ARM has also been significantly optimized to cut down on time. There is less verbose and c-ares + curl is built with a much more efficient cmake process.

These changes will make it much easier to develop/maintain the docker container. Everything is working fast and flawlessly now.