crazy-max / docker-rtorrent-rutorrent

rTorrent and ruTorrent Docker image
MIT License
501 stars 111 forks source link

Improve c-ares & curl build process #295

Closed stickz closed 11 months ago

stickz commented 11 months ago

This commit improves the c-ares and curl build process to use cmake instead. This is a much better choice for docker container. We do not require the features GNU Make provides. CMake should also be more stable for testing pull requests on GitHub.

It also upgrades the c-ares and curl version to receive the latest bug fixes and performance changes. There's been a huge leap forward since the older changes. Put simple, curl 8 is faster. https://daniel.haxx.se/blog/2023/04/28/curl-8-is-faster/

stickz commented 11 months ago

AMD64 job completed in 5m instead of 7m. This is from the build log showing the new version of curl is working properly.

#102 8.742 curl 8.5.0 (Linux) libcurl/8.5.0 OpenSSL/3.1.4 zlib/1.2.13 brotli/1.0.9 zstd/1.5.5 c-ares/1.24.0
#102 8.742 Release-Date: 2023-12-06
#102 8.742 Protocols: dict file ftp ftps gopher gophers http https imap imaps mqtt pop3 pop3s rtsp smb smbs smtp smtps telnet tftp
#102 8.742 Features: alt-svc AsynchDNS brotli HSTS HTTPS-proxy IPv6 Largefile libz NTLM SSL threadsafe TLS-SRP UnixSockets zstd

We will get results from ARM when it completes in 45m instead of 55m. 👍

stickz commented 11 months ago

This is from ARMv6. All the ARM containers have the same results. It completed in 42m down from 56m.

#102 38.54 curl 8.5.0 (Linux) libcurl/8.5.0 OpenSSL/3.1.4 zlib/1.2.13 brotli/1.0.9 zstd/1.5.5 c-ares/1.24.0
#102 38.54 Release-Date: 2023-12-06
#102 38.54 Protocols: dict file ftp ftps gopher gophers http https imap imaps mqtt pop3 pop3s rtsp smb smbs smtp smtps telnet tftp
#102 38.54 Features: alt-svc AsynchDNS brotli HSTS HTTPS-proxy IPv6 Largefile libz NTLM SSL threadsafe TLS-SRP UnixSockets zstd