search

crazy-max / docker-rtorrent-rutorrent

rTorrent and ruTorrent Docker image
MIT License
501 stars 111 forks source link

Health probes are not working when auth is added #313

Open ac1dburnz opened 10 months ago

ac1dburnz commented 10 months ago

Support guidelines

I've found a bug and checked that ...

Description

When you add passwords with:

htpasswd -Bbn admin password >> $(pwd)/passwd/webdav.htpasswd htpasswd -Bbn admin password >> $(pwd)/passwd/rutorrent.htpasswd

htpasswd -Bbn admin password >> $(pwd)/passwd/rpc.htpasswd

the liveness, readiness and startup probs stop working. This is occurring on truenas scale which uses the docker image with Kubs.

Expected behaviour

When you add basic auth the probes still work

Actual behaviour

Error occurs when you add base auth

2024/01/11 00:05:18 [info] 561#561: 1 no user/password was provided for basic authentication, client: 192.168.2.185, server: , request: "GET /plugins/diskspace/action.php?=1704948204387 HTTP/1.1", host: "192.168.2.7:8080", referrer: "http://192.168.2.7:8080/" 2024-01-11 00:05:18.039287-05:00192.168.2.185 - - [11/Jan/2024:00:05:18 -0500] "GET /plugins/diskspace/action.php?=1704948204387 HTTP/1.1" 401 574 "http://192.168.2.7:8080/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36" 2024-01-11 00:05:24.514639-05:002024/01/11 00:05:24 [info] 561#561: 2 no user/password was provided for basic authentication, client: 192.168.2.185, server: , request: "GET /plugins/diskspace/action.php?=1704948178686 HTTP/1.1", host: "192.168.2.7:8080", referrer: "http://192.168.2.7:8080/" 2024-01-11 00:05:24.514645-05:00192.168.2.185 - - [11/Jan/2024:00:05:24 -0500] "GET /plugins/diskspace/action.php?=1704948178686 HTTP/1.1" 401 172 "http://192.168.2.7:8080/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.0 Safari/605.1.15"

it will shut down after a bit

Steps to reproduce

install and add basic auth

Docker info

n/a

Docker Compose config

n/a

Logs

2024/01/11 00:05:18 [info] 561#561: *1 no user/password was provided for basic authentication, client: 192.168.2.185, server: , request: "GET /plugins/diskspace/action.php?_=1704948204387 HTTP/1.1", host: "192.168.2.7:8080", referrer: "http://192.168.2.7:8080/"
2024-01-11 00:05:18.039287-05:00192.168.2.185 - - [11/Jan/2024:00:05:18 -0500] "GET /plugins/diskspace/action.php?_=1704948204387 HTTP/1.1" 401 574 "http://192.168.2.7:8080/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36"
2024-01-11 00:05:24.514639-05:002024/01/11 00:05:24 [info] 561#561: *2 no user/password was provided for basic authentication, client: 192.168.2.185, server: , request: "GET /plugins/diskspace/action.php?_=1704948178686 HTTP/1.1", host: "192.168.2.7:8080", referrer: "http://192.168.2.7:8080/"
2024-01-11 00:05:24.514645-05:00192.168.2.185 - - [11/Jan/2024:00:05:24 -0500] "GET /plugins/diskspace/action.php?_=1704948178686 HTTP/1.1" 401 172 "http://192.168.2.7:8080/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.0 Safari/605.1.15"

Additional info

No response

crazy-max commented 5 months ago

the liveness, readiness and startup probs stop working.

Not sure what this means but health check for the container is used here: https://github.com/crazy-max/docker-rtorrent-rutorrent/blob/cfea5dcd855334901f4ad86b7235600a8cc4033b/Dockerfile#L252-L253

https://github.com/crazy-max/docker-rtorrent-rutorrent/blob/cfea5dcd855334901f4ad86b7235600a8cc4033b/rootfs/usr/local/bin/healthcheck#L4-L11

There is an additional nginx configuration for each probes which does not have any authentication as we only expose the service on 127.0.0.1: