crazy-max / ghaction-github-labeler

GitHub Action to manage labels on GitHub
https://github.com/marketplace/actions/github-labeler
MIT License
143 stars 17 forks source link

The github-token parameter has a default value and it's not required #154

Closed TomerFi closed 1 year ago

TomerFi commented 2 years ago

Hello

Thank you for this great action. A small contribution, the github-token parameter has a default value, so it can be marked as not required.

crazy-max commented 1 year ago

parameter has a default value

The default value can be empty on GHES, that's why it's marked as required.

TomerFi commented 1 year ago

@crazy-max It has nothing to do whether or not the value can an empty string or not, this simply controls the action's behaviour.

Marking an action field as required means that users REQUIRED provide it, the action will FAIL if the field isn't provided.

Assigning a default value to an action field means that if users WON'T provide their own value, the action will USE THE DEFAULT value instead.

Marking an action field as required and set it with a default value, means the required property is redundant and has no affect on the action behavior.