search

crazy-max / ghaction-github-labeler

GitHub Action to manage labels on GitHub
https://github.com/marketplace/actions/github-labeler
MIT License
143 stars 17 forks source link

Sanitize the color field to allow using hex codes #207

Closed pjpires closed 10 months ago

pjpires commented 10 months ago

Found myself struggling with the color field, as I was unfamiliar with the underlying GitHub API.

This PR fixes #153 and adds a test scenario for hex code colors. Replaces and closes #172.

pjpires commented 10 months ago

Looks good but can you:

* squash your commits

* run `docker buildx bake pre-checkin` per [`master`/.github/CONTRIBUTING.md#submitting-a-pull-request](https://github.com/crazy-max/ghaction-github-labeler/blob/master/.github/CONTRIBUTING.md?rgh-link-date=2024-02-06T14%3A26%3A35Z#submitting-a-pull-request)

* push commit with generated files changes similar to [#187 (commits)](https://github.com/crazy-max/ghaction-github-labeler/pull/187/commits) with commit message `update generated content`

Thanks!

Sorry, I've read the contributing instructions but I didn't get that you meant the result of running docker buildx bake pre-checkin to be a separate commit. Can you please double check if everything looks good now? Thanks!