Closed verdverm closed 1 year ago
Remove this: https://github.com/hofstadter-io/hof/blob/451d5563b470bf57ef278b977f12b396af65c72a/.github/workflows/hof.yml#L57-L58
This action already sets the right Docker context: https://github.com/hofstadter-io/hof/actions/runs/4321103204/jobs/7541988936#step:8:264
Sorry, I did not get perma-links, I have added those since creating this. It was not working without them
I don't think the Go client is working with non-default contexts, or I haven't figured out how to use the current selected one
Sorry, I did not get perma-links, I have added those since creating this. It was not working without them
I don't think the Go client is working with non-default contexts, or I haven't figured out how to use the current selected one
You don't need to enforce DOCKER_HOST
here:
- name: Setup Docker MacOS var
run: echo "DOCKER_HOST="unix://$HOME/.colima/default/docker.sock"" >> $GITHUB_ENV
Apparently the Go client doesn't understand the docker contexts that the docker
cli manages. https://github.com/moby/moby/discussions/44166
I think the only way to get this to work with the Go client is to use the DOCKER_HOST variable. https://github.com/hofstadter-io/hof/actions/runs/4321103204/jobs/7541988936#step:10:97
The correct value is DOCKER_HOST="unix://$HOME/.colima/default/docker.sock"
Oh my bad, didn't catch you were using the Go client. Then yes setting DOCKER_HOST
should do the trick.
It's now failing when talking to the containers. Do I have to do anything different with ports?
https://github.com/hofstadter-io/hof/actions/runs/4321328600/jobs/7542436289#step:19:247
Sorry I don't know you codebase. If you have a simple repro, happy to take a look.
I ended up just needing to ensure the DOCKER_HOST was propagated to the proper test setups. All is good now. Thanks for making this and pointing me at this project from my other issues.
Behaviour
Steps to reproduce this issue
go run main.go
on amacos-latest
runner after this actionhttps://github.com/hofstadter-io/hof/blob/ci-docker/test/docker/main.go
Expected behaviour
The Go client should be able to query and start containers on macos
Actual behaviour
Configuration
https://github.com/hofstadter-io/hof/blob/3e100d5604eb7bf983499b13d21637283fff6158/.github/workflows/hof.yml#L52
Logs
https://github.com/hofstadter-io/hof/actions/runs/4321103204/jobs/7541988936