search

crazy365966834 / flutter_cupertino_localizations

MIT License
7 stars 18 forks source link

GlobalCupertinoLocalizations is missing some getters from CupertinoLocalizations #2

Open Andrious opened 5 years ago

Andrious commented 5 years ago

I'm not certain, but I think GlobalCupertinoLocalizations is missing some getters from CupertinoLocalizations. I'm going through the Setting up an internation­alized app: the flutter_localizations package, and I'm getting the following error, when trying to Internation­alize an app:

The non-abstract class 'CupertinoLocalizationAr' is missing implementations for these members:

DatePickerDateOrder get datePickerDateOrder;
DatePickerDateTimeOrder get datePickerDateTimeOrder;
String get todayLabel;

Reference: abstract class GlobalCupertinoLocalizations implements CupertinoLocalizations abstract class CupertinoLocalizations

nelsyeung commented 4 years ago

You do not need this package anymore to use cupertino localizations. This package will not work with the latest flutter.

SaloGala commented 4 years ago

@nelsyeung So should we use GlobalCupertinoLocalizations.delegate from this package?:

import 'package:flutter_localizations/flutter_localizations.dart';

I'm talking on context of this issue.

nelsyeung commented 4 years ago

@SaloGala I don't think we should use anything from this package anymore. I found no problem just removing this package entirely. I believe Flutter has added full Cupertino support since Flutter 1.13 or maybe even slightly earlier.