search

crc-org / crc-cloud

Disposable OpenShift instances on cloud in minutes
31 stars 19 forks source link

Add gcp provider support #141

Closed praveenkumar closed 9 months ago

adrianriobo commented 12 months ago

Can we add some README content on how to use the gcp, some code snippet on how to invoke the container or the binary? Envs required....

Also did you give a try to build a container and run from it AFAIK we will need to add the gcp cli to the container as well...may at https://github.com/crc-org/crc-cloud/blob/main/requirements.txt

praveenkumar commented 9 months ago

Can we add some README content on how to use the gcp, some code snippet on how to invoke the container or the binary? Envs required....

Yes I updated the README which have all the steps and usecase.

Also did you give a try to build a container and run from it AFAIK we will need to add the gcp cli to the container as well...may at https://github.com/crc-org/crc-cloud/blob/main/requirements.txt

gcp cli added as part of container image, I am not sure why requirements.txt is there ?

adrianriobo commented 9 months ago

gcp cli added as part of container image, I am not sure why requirements.txt is there ?

need to add both the pulumi plugin for gpc and the gcp cli I only see the the pulumi plugin, also that requirements is a way to manage tooling through pip if I am not wrong, so maybe you can just add a new line for the gcp cli there. AFAIK the benefit to handle it within the requirements.txt is that renovate acts on it out of the box.

praveenkumar commented 9 months ago

need to add both the pulumi plugin for gpc and the gcp cli I only see the the pulumi plugin

Why I need to add gcp cli, I created the image using this container and able to create cluster using this image.

that requirements is a way to manage tooling through pip if I am not wrong

But where are we using this requirements only for renovate?

adrianriobo commented 9 months ago

But where are we using this requirements only for renovate?

Not only for renovate we are using it as an unified way for pkg management (+ it is supported by renovate).

So pros is we have a unified way to handle pkgs... cons is aws cli v2 is not supported there...on qenvs I use a different approach for each cli.

adrianriobo commented 9 months ago

As a side note I realize you are using gcp classic provisioner https://github.com/pulumi/pulumi-gcp recently pulumi shift the way they create the provisioners to a native way using the cloud providers API https://github.com/pulumi/pulumi-google-native

It seems pulumi recommendation is to move to native provisioners...but they are not mature enough as an example I was able to use the azure native but not the aws as it misses still lot of resources... so add this as a comment we may can create a following issue as spike to migrate the gcp to the native provisioner WDYT?

praveenkumar commented 9 months ago

It seems pulumi recommendation is to move to native provisioners...but they are not mature enough as an example I was able to use the azure native but not the aws as it misses still lot of resources... so add this as a comment we may can create a following issue as spike to migrate the gcp to the native provisioner WDYT?

As per https://github.com/pulumi/pulumi-google-native looks like it is not stable and development is in active state so better to have follow up issue in case we want to switch over in near future.