search

crc-org / crc-cloud

Disposable OpenShift instances on cloud in minutes
31 stars 20 forks source link

[Enhancement] adding a custom third option for a nameserver to be used on the cluster instance #39

Open adrianriobo opened 1 year ago

adrianriobo commented 1 year ago

When setting up the dns server ips we are adding our crc-dnsmasq ip for our internals, and 169.254.169.254 for cloud provider internal resolutions.

We rely on the case were the instance we are spinning already contains some public fallback dns server on /etc/resolv.conf which may not be the case.

Would it make sense to add there a third server for public fallback (something like 9.9.9.9) ?

adrianriobo commented 1 year ago

A specific use case for this is IBM Cloud where according to its documentation to enable dynamic NIC we need to include RMC with our custom image and due to been a proprietary software from IBM we will not able to ship our images with it https://bugzilla.redhat.com/show_bug.cgi?id=1819569

As so when provisioning a machine with power VS on IBM Cloud without it network setup will not be setup so no public dns will be configured at all

praveenkumar commented 1 year ago

https://github.com/crc-org/crc-cloud/blob/main/pkg/bundle/setup/clustersetup.sh#L120 may be just add 1.1.1.1 here. or We can create an option in the create command for providing the nameserver and pass it to this setup script.