search

crc-org / crc-extension

Red Hat OpenShift Local Extension for integration of OpenShift Local clusters with Podman Desktop
Apache License 2.0
17 stars 20 forks source link

Handle need to recreate and cancel #131

Closed gbraad closed 1 year ago

gbraad commented 1 year ago

The user can cancel the preset with 'cancel' (and 'X') and will only ask the user to delete the preset when it differs from the current one.

evidolob commented 1 year ago

Preset change doesn’t work for me, whatever I select on preset list, it doesn’t applied on crc config

gbraad commented 1 year ago

I tried this again and works image

I set the preset to microshift on start. the bottom powershell shows this. I change it to openshift... but have to wait quite long before the dialog shows... I check the value and it removed microshift. then when I 'cancel' (or 'X') it will default BACK to microshift as you cancelled. any other value will perform the delete as instructed.

I do not prevent the configSet to happen... I only perform an 'undo' at the time the user cancels.

evidolob commented 1 year ago

Preset change still doesn’t work for me:

https://github.com/crc-org/crc-extension/assets/929743/fd187bd3-2ea2-42d1-8930-bbc4ed03d38b

gbraad commented 1 year ago

For you, the whole dialog doesn't even pop up to "recreate". Can you see if the event actually goes through, or if there is an error ?

gbraad commented 1 year ago

@evidolob you mentioned something else is the root cause of this?