search

crc-org / crc-extension

Red Hat OpenShift Local Extension for integration of OpenShift Local clusters with Podman Desktop
Apache License 2.0
17 stars 19 forks source link

Remove connection factory when crc has instance #167

Closed evidolob closed 1 year ago

evidolob commented 1 year ago

Fix #122

Demo:

https://github.com/crc-org/crc-extension/assets/929743/c65a740e-7f04-4df7-a5e3-6c27d693e312

gbraad commented 1 year ago

The last step is confusing; the close and create buttons have been removed and the user has to resort to using the cross (X) to close the creation pane.

evidolob commented 1 year ago

That is out of our control, that is PD does. I don't change that part in this PR. This PR is only about hiding Create new... button, when CRC has an instance.

evidolob commented 1 year ago

The last step is confusing; the close and create buttons have been removed and the user has to resort to using the cross (X) to close the creation pane.

That was caused be my changes, look like PD removes that buttons after crc-extension remove connection factory. I kinda fix that:

https://github.com/crc-org/crc-extension/assets/929743/2f3795ed-17d8-4ffc-baa9-251f8a27038b