search

crc-org / crc-extension

Red Hat OpenShift Local Extension for integration of OpenShift Local clusters with Podman Desktop
Apache License 2.0
13 stars 16 forks source link

Notification shown after sucessful push to local cluster is very hard to notice #185

Closed dgolovin closed 7 months ago

dgolovin commented 8 months ago

On macOS notification is not visible right away and to see it I have to go to tray and click on date to see that image push was successful. On fedora it seems not showing up at all (it could be notification permission not set in settings). Other extensions are using window.showInformationMessage which shows modal message dialog inside podman window. Would be good to use this simple approach across all push commands.

https://github.com/crc-org/crc-extension/blob/caccc05c969e75cfdebe7beef3ba6559021eeaca/src/image-handler.ts#L71

This issues is related to https://github.com/containers/podman-desktop/issues/3538.

gbraad commented 8 months ago

Other extensions are using window.showInformationMessage which shows modal message dialog inside podman window. Would be good to use this simple approach across all push commands.

The use of a modal window does not look like the ideal solution.

We have discussed this before, and this should be part of the 'tasks'. they will then end up in a trackable list and show progress and completion consistently. Unfortunately, we are not aware if this functionality is now available/finalized.

gbraad commented 8 months ago

I believe this is called now the 'Bell icon' list? https://github.com/containers/podman-desktop/issues/4406

dgolovin commented 8 months ago

Tasks are good solution to show progress, but there is no any visual information on that bell when task(s) finished.

I agree that showing modal dialog is not ideal, but it is better that show something that is not easy to notice. There should be some sort of non blocking notification, but we don't have it right now.

dgolovin commented 8 months ago

I believe this is called now the 'Bell icon' list? https://github.com/containers/podman-desktop/issues/4406

Correct.

gbraad commented 8 months ago

don't have it right now

hence we delivered with the current Notifications. We hoped this would be available soon-ish. Notifications are very dependent on the OS and can, especially in the case of macOS be hidden (never show up), and in the case of Linux not be properly supported. If the other extensions use the modal form, this might work as a workaround... but this has t o be temporary. Modal dialogs should only be reserved for blocking tasks like a setup.

dgolovin commented 8 months ago

I agree crc-extension should show informaton message for now as temp solution. Implementation for information message at some point will be done in a form non blocking message dialog, the same way as tasks view shows tasks.

gbraad commented 7 months ago

Follow-up issue is filed here: https://github.com/crc-org/crc-extension/issues/191