search

crc-org / crc-extension

Red Hat OpenShift Local Extension for integration of OpenShift Local clusters with Podman Desktop
Apache License 2.0
17 stars 20 forks source link

Add OC login copy commands #48

Closed evidolob closed 1 year ago

evidolob commented 1 year ago

Demo:

https://user-images.githubusercontent.com/929743/232708809-01596bde-7bad-4e75-b52d-1ce09b873360.mov

PR also fixes https://github.com/crc-org/crc-extension/issues/46

Note: Copy* commands are shown only for OpenShift preset as MicroShift doesn’t provide necessary information

cfergeau commented 1 year ago

Fwiw, the ingress certificate error from oc should be fixed in https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp/candidate-4.12/

I don't know if we should expose oc login in the UI, or oc config set-context, the latter seems more in line with what podman desktop is doing ( https://podman-desktop.io/docs/kubernetes/kind/creating-a-kind-cluster - « In the Podman Desktop tray, open the Kubernetes menu, you can set the context to your Kind cluster: kind-. » )

gbraad commented 1 year ago

I don't know if we should expose oc login in the UI,

You would suggest not to have these clipboard options?

« In the Podman Desktop tray, open the Kubernetes menu, you can set the context to your Kind cluster: kind-. » )

That would be the better option...

... however, we also try to stay close to the current tray we are offering. When functionality is more rounded and complete, we could decide to drop these options, although a 'copy password' to clipboard might take the place for use in the console.