crc-org / crc-extension

Red Hat OpenShift Local Extension for integration of OpenShift Local clusters with Podman Desktop
Apache License 2.0
17 stars 20 forks source link

Pull-secret dialog alternative #56

Closed gbraad closed 1 year ago

gbraad commented 1 year ago

We need to come up with a solution to more clearly indicate the location to get the pull-secret, as the palette option is hard to understand; not very visible and provides no information on the next step to solve this.

While we have:

It is not clear when this will be available.

gbraad commented 1 year ago

We might be able to add a temporary dialog inside the askAndStorePullSecret function:

extensionApi.window.showInformationMessage(`To pull container images from the registry, a pull secret is necessary.
  You can get a pull secret from the Red Hat OpenShift Local download page.
  Use the "Copy pull secret" option and paste the content.

  https://cloud.redhat.com/openshift/create/local`);

Two issues here, it is shown before the actual step where it is necessary, which is not ideal though still better than the current situation. But second, this does not allow the link to be highlighted and clicked on.

@evidolob what are your thoughts on this?

slemeur commented 1 year ago

Yes, we should provide a quick fix for this until we have a better solution to handle the modal dialog in the API of podman-desktop extensions. Suggestion from @gbraad is nice!

slemeur commented 1 year ago

Could we have that message in the placeholder being displayed both in the command palette and in the preferences?

gbraad commented 1 year ago

We have also added a clear 'Obtain Pull-secret' on the dashboard, right under the initialize button.

Will see how much we can fit in the Preferences.

slemeur commented 1 year ago

thanks @gbraad !

gbraad commented 1 year ago

Ideally, this would have been a single dialog;

image

Preferences already uses: https://github.com/crc-org/crc-extension/blob/142e30a4580beae9d620d890fbb685d554615b7e/package.json#L53-L53 but does not get properly rendered by PD. /cc: @jeffmaury