crc-org / crc-extension

Red Hat OpenShift Local Extension for integration of OpenShift Local clusters with Podman Desktop
Apache License 2.0
17 stars 20 forks source link

Open Dev Terminal is not Windows friendly #65

Closed jeffmaury closed 1 year ago

jeffmaury commented 1 year ago

Seems to initialize using sh/bash command:

image

gbraad commented 1 year ago

According to my limited French understanding I see it does not understand export. This should however not be part of the oc-env command...

Can you provide more information abput your environment and perhaps in a Windows-Terminal PowerShell session run crc oc-env to see what the output is that is given to execute.

jeffmaury commented 1 year ago

So I was running my debug session from a bash shell in Windows which gives:

$ crc oc-env
export PATH="C:\Users\Jeff\.crc\bin\oc:$PATH"
# Run this command to configure your shell:
# eval $(crc oc-env)

The same in PowerShell:

PS C:\Users\Jeff\apps\crc\2.17.0> crc oc-env
$Env:PATH = "C:\Users\Jeff\.crc\bin\oc;$Env:PATH"
# Run this command to configure your shell:
# & crc oc-env | Invoke-Expression
PS C:\Users\Jeff\apps\crc\2.17.0>
gbraad commented 1 year ago

so the command reports what is expected. however, in the session spawned it identifies as bash... looks like a terminal configuration issue. can you share your config? note: unable to reproduce

--

Gerard Braad | http://gbraad.nl

STEM is the source, but BUILD is how you develop! [ Better Understanding Involves Learning and Doing ]

gbraad commented 1 year ago

@jsliacan or @anjannath can you have a look at this to repro?

anjannath commented 1 year ago

@jeffmaury I think this only occurs when the user launches the podman-desktop app itself from a bash shell ? like run yarn desk:run from the bash/cygwin shell

so to reproduce i first installed Podman desktop using the MSI then installed the crc-extension -> started the microshift preset -> click on "Open developer console" and it launched powershell with the required oc env variables set

2023-05-04-13-15-24.webm

gbraad commented 1 year ago

@jeffmaury was bash used to start Podman desktop?

jeffmaury commented 1 year ago

@jeffmaury was bash used to start Podman desktop?

git-bash to be exact

gbraad commented 1 year ago

When PD is 'installed' on Windows, isn't the application started from the Start Menu instead?