search

crc-org / crc-extension

Red Hat OpenShift Local Extension for integration of OpenShift Local clusters with Podman Desktop
Apache License 2.0
13 stars 16 forks source link

After installation reboot msg box is concealed by preset selection msg box #93

Closed anjannath closed 1 year ago

anjannath commented 1 year ago

Versions

OS: Windows 10 Pro
podman-desktop:  built from master
CRC extension: ghcr.io/crc-org/crc-extension:latest

After finishing the installation for CRC to work, we need to reboot the machine, while doing the installation from the extension/podman-desktop this is notified to the user via a message box that asks user to reboot, but after a few seconds of showing the msg box a new msg box is shown asking the user to select a preset and once selection is made or cancelled in which case the default preset is used, it goes on to download the bundle.

Screen recording of the above flow

reboot_msg_blocked_by_preset_msg.webm

Trying to start CRC and go on with the suggested flow will eventually lead to the following error: extension_setup_needs_reboot

Q: Should we wait till the user reboots to show the preset selection msg box next time podman-desktop is started? as without a reboot user won't be able to use CRC. Q: Can we put a Reboot button on the msg box that notifies the user to just click and reboot the machine?

gbraad commented 1 year ago

@evidolob WDYT can be done?

anjannath commented 1 year ago

Jeff pointed to the following line of code, (copied from #95)

https://github.com/crc-org/crc-extension/blob/d4f6b39b099f8a6cf3fea8f26929bb9291527c98/src/install/win-install.ts#L49

gbraad commented 1 year ago

It returns true to indicate the installation successfully finished. In this case you might need a tri-state; true, false, not-really for the situation of a needed reboot.