crc-org / crc-extension

Red Hat OpenShift Local Extension for integration of OpenShift Local clusters with Podman Desktop
Apache License 2.0
13 stars 16 forks source link

Add license to package.json #94

Closed jeffmaury closed 1 year ago

jeffmaury commented 1 year ago

yarn build reports:

warning ..\..\..\..\..\package.json: No license field
warning openshift-local@0.0.1: The engine "podman-desktop" appears to be invalid.
$ rollup --bundleConfigAsCjs --config rollup.config.js --compact --environment BUILD:production

src/extension.ts, node_modules/hasha/thread.js → dist...
(!) "this" has been rewritten to "undefined"
https://rollupjs.org/troubleshooting/#error-this-is-undefined
node_modules/form-data-encoder/lib/FormDataEncoder.js
1: var __classPrivateFieldSet = (this && this.__classPrivateFieldSet) || function (receiver, state, value, kind, f) {
                                 ^
2:     if (kind === "m") throw new TypeError("Private method is not writable");
3:     if (kind === "a" && !f) throw new TypeError("Private accessor was defined without a setter");
...and 3 other occurrences
created dist in 6.1s
Done in 7.90s.
gbraad commented 1 year ago

Not sure where that comes from:

https://github.com/crc-org/crc-extension/blob/44f11280ef29872d0ca320a2a20693c82787d988/package.json#L8

as we have the license specified.

Check if ..\..\..\..\..\package.json is not pointing to a stray package.json file. As when I made one in a lower path it started to use/parse this one:

PS> yarn --
yarn install v1.22.19
warning ..\..\package.json: No license field
warning package-lock.json found.

and when removed.

PS> yarn --
yarn install v1.22.19
warning package-lock.json found. 

This is not a build issue, but rather yarn finding something way way way down in the structure.