search

crc-org / crc

CRC is a tool to help you run containers. It manages a local OpenShift 4.x cluster, Microshift or a Podman VM optimized for testing and development purposes
https://crc.dev
Apache License 2.0
1.26k stars 238 forks source link

Additional hosts added in hosts file should be clearly identified coming from crc #1695

Open guillaumerose opened 3 years ago

guillaumerose commented 3 years ago

goodhost adds hosts to the hosts file but it is not clear in the file. We should have comments around our changes like:


127.0.0.1 localhost

# these entries were added by crc
x.x.x.x api.crc.testing
# end
``
cfergeau commented 3 years ago

Would be very useful for crc cleanup

anjannath commented 3 years ago

This was handled in https://github.com/code-ready/crc/pull/1722 or is there something left?

guillaumerose commented 3 years ago

No, it still needs to be done.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

cfergeau commented 3 years ago

This is still an issue.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.