More 'OpenShift cluster/instance'/'virtual machine' occurrences

[cfergeau]

This issue is a followup to https://github.com/code-ready/crc/commit/e2a76bbba5653a2c9046efce6753f075057cda06 The conversation below happened in https://github.com/code-ready/crc/pull/3007

git grep -i 'openshift instance' and git grep -i 'virtual machine' still return a few results so it's not just e2e which was missed.

On pkg and test side only those places are remaining but there is lot of place in the doc which mention virtual machine so @robin-owen should let us know if we need to changes those with instance.

cmd/crc/cmd/podman_env.go:      podmanEnvCmd.Flags().BoolVar(&root, "root", false, "Use root podman in the virtual machine")
pkg/crc/config/settings.go:             fmt.Sprintf("Virtual machine preset (alpha feature - valid values are: %s or %s)", preset.Podman, preset.OpenShift))
pkg/crc/machine/config/config.go:       // Virtual machine configuration
pkg/crc/machine/console.go:             return nil, errors.Wrap(err, "Error getting the state for virtual machine")
pkg/crc/machine/start.go:               return nil, errors.Wrap(err, "Failed to connect to the CRC VM with SSH -- virtual machine might be unreachable")
pkg/crc/machine/start.go:               return fmt.Errorf("Too little memory (%s) allocated to the virtual machine to start the monitoring stack, %s is the minimum",
pkg/crc/machine/start.go:               return fmt.Errorf("Error saving virtual machine to store after attempting creation: %s", err)
pkg/crc/machine/status.go:              return nil, errors.Wrap(err, fmt.Sprintf("Cannot load '%s' virtual machine", client.name))
pkg/crc/machine/sync.go:                logging.Infof("Cancelling virtual machine start...")
pkg/crc/preflight/preflight_checks_windows.go:  // Check if Hyper-V's Virtual Machine Management Service is running
pkg/crc/preflight/preflight_checks_windows.go:          return fmt.Errorf("Hyper-V Virtual Machine Management service not running")
pkg/crc/preflight/preflight_linux.go:                   cleanupDescription: "Removing crc's virtual machine",
pkg/crc/preflight/preflight_windows.go:         cleanupDescription: "Removing crc's virtual machine",
test/e2e/features/basic.feature:        Then stderr should contain "Removing crc's virtual machine"
test/e2e/features/basic.feature:        And stderr should contain "Removing crc's virtual machine"

[cfergeau]

There's also

cmd/crc/cmd/bundle/generate.go:         Short: "Generate a custom bundle from the running OpenShift cluster",
cmd/crc/cmd/bundle/generate.go:         Long:  "Generate a custom bundle from the running OpenShift cluster",
cmd/crc/cmd/ip.go:      Short: "Get IP address of the running OpenShift cluster",
cmd/crc/cmd/ip.go:      Long:  "Get IP address of the running OpenShift cluster",
cmd/crc/cmd/status.go:  Short: "Display status of the OpenShift cluster",
cmd/crc/cmd/status.go:  Long:  "Show details about the OpenShift cluster",

And possibly

cmd/crc/cmd/console.go:         return errors.New("The OpenShift cluster is not running, cannot open the OpenShift Web Console")
cmd/crc/cmd/start.go:   startTemplateForOpenshift = `Started the OpenShift cluster.
pkg/crc/machine/start.go:       logging.Info("Starting OpenShift cluster... [waiting for the cluster to stabilize]")

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.