search

crc-org / crc

CRC is a tool to help you run containers. It manages a local OpenShift 4.x cluster, Microshift or a Podman VM optimized for testing and development purposes
https://crc.dev
Apache License 2.0
1.25k stars 236 forks source link

`crc version` should not interact with daemon #3407

Open praveenkumar opened 1 year ago

praveenkumar commented 1 year ago

Right now crc version command have OpenShift/Podman version information which is used during the build of crc binary. Since 2.9.0, users are allowed to use different Openshift/Podman bundle so crc status command is much accurate around which version of Openshift/Podman is running. We can safely remove this information from the crc version now which make crc version not to depend on those components. Also we are moving all the commands to interact with daemon and version command doesn't fit to have daemon as requirement. A user should able to download the respective crc binary and get the version without running crc setup or starting the daemon manually.

cfergeau commented 1 year ago

The version of crc can be printed without going through the daemon. Regarding OpenShift/Podman (and OKD) versions, the versions hardcoded in the binary indicate that it's the default OpenShift/Podman/OKD version that the binary is going to use, and these versions have been tested by QE with this binary, so they are known to be working. Imo this is useful information to have, so it makes sense to keep them in crc version. For these OpenShift/Podman/OKD versions, I would get them through the daemon, one day we might add support for remote daemon or such, and these versions could differ from the local binary. A "daemon version" could be useful to have as well in crc version output.